Skip to content

feat: optimize Dockerfile #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JavierMonton merged 5 commits into from
Mar 25, 2026
Merged

feat: optimize Dockerfile #3

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ada986
reorder install syntax and use docker cache
duhow Mar 25, 2026
0952903
add npm cache and chmod file directly
duhow Mar 25, 2026
cf807de
add VOLUME to persisting path
duhow Mar 25, 2026
212b3f1
move entrypoint to base stage
duhow Mar 25, 2026
5939b25
multi-stage with single chown - avoids duplicate layer
duhow Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 23 additions & 11 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,52 @@
# syntax=docker/dockerfile:1
# Renfe Tracker – FastAPI app (Python 3.11, uv) with a React+Tailwind frontend build.

FROM node:20-slim AS frontend-build
WORKDIR /frontend
COPY frontend/package.json frontend/package-lock.json ./
RUN npm ci
RUN --mount=type=cache,target=/root/.npm/ \
npm ci
COPY frontend/ ./
RUN npm run build

FROM python:3.11-slim
FROM python:3.11-slim AS base

# Install uv and gosu (entrypoint fixes volume permissions so app can create DB on first run)
RUN --mount=type=cache,target=/root/.cache/pip/ \
--mount=type=cache,target=/var/lib/apt/ \
--mount=type=cache,target=/var/cache/apt/ \
pip install uv \
&& apt-get update && apt-get install -y --no-install-recommends gosu

COPY --chmod=0755 entrypoint.sh /entrypoint.sh
WORKDIR /app

# Install uv and gosu (entrypoint fixes volume permissions so app can create DB on first run)
RUN pip install --no-cache-dir uv \
&& apt-get update && apt-get install -y --no-install-recommends gosu \
&& rm -rf /var/lib/apt/lists/*
FROM base AS dependencies

# Install project and dependencies with uv (frozen lockfile)
COPY pyproject.toml uv.lock README.md ./
RUN --mount=type=cache,target=/root/.cache/uv/ \
uv sync --frozen --no-dev

FROM base AS app

COPY app/ app/
COPY renfe_mcp/ renfe_mcp/
# Bundle i18n translation files so the backend can generate localised emails
COPY frontend/src/i18n/ app/i18n/
RUN uv sync --frozen --no-dev

# Replace static assets with compiled React build
COPY --from=frontend-build /frontend/dist/ app/static/

# Default run user is 1000:1000; override at runtime with PUID/PGID. No named user needed (entrypoint uses gosu with numeric id).
RUN chown -R 1000:1000 /app
FROM base AS final

COPY entrypoint.sh /entrypoint.sh
RUN chmod +x /entrypoint.sh
# Default run user is 1000:1000; override at runtime with PUID/PGID. No named user needed (entrypoint uses gosu with numeric id).
COPY --chown=1000:1000 --from=dependencies /app /app
COPY --chown=1000:1000 --from=app /app /app

ENV HOME=/app
ENV DATA_DIR=/data
VOLUME [ "/data" ]
EXPOSE 8000
ENTRYPOINT ["/entrypoint.sh"]
CMD ["uv", "run", "uvicorn", "app.main:app", "--host", "0.0.0.0", "--port", "8000"]
Loading