Skip to content

[19.0][MIG] pos_sale_picking_keep#2

Merged
alan196 merged 12 commits into
Jarsa:19.0from
Jarsa-dev:19.0-mig-pos_sale_picking_keep
Jun 27, 2026
Merged

[19.0][MIG] pos_sale_picking_keep#2
alan196 merged 12 commits into
Jarsa:19.0from
Jarsa-dev:19.0-mig-pos_sale_picking_keep

Conversation

@alan196

@alan196 alan196 commented Jun 27, 2026

Copy link
Copy Markdown

Migration of pos_sale_picking_keep from 18.0 to 19.0 (based on OCA/pos:19.0).

Migration changes

  • Bump manifest version to 19.0.1.0.0.
  • Add sale_stock dependency: pos_sale loads sale.order.picking_ids in the PoS data, a field provided by sale_stock. It is auto_install so it is normally present, but it is not pulled in the minimal CI install, which made the PoS fail to load with Invalid field 'picking_ids' on 'sale.order'. The module also operates on the sale order stock moves/pickings, so the dependency is required.
  • Update the PoS test tour imports to the new 19.0 paths (tests/pos/tours/utils/* and tests/generic_helpers/dialog_util).
  • Grant sales_team.group_sale_salesman in the test setup: in 19.0 point_of_sale.group_pos_manager no longer implies sales rights and the web onchange now checks create access, so creating the sale order raised AccessError.
  • Use f-strings for the tour URLs (ruff UP031).
  • Add readme/CONTRIBUTORS.md and regenerate the README.

Both PoS tours pass. Upstream PR: OCA#1576.

Note: also includes 4 Weblate (German) translation commits that are already in OCA/pos:19.0 and that this Jarsa branch did not yet have.

intero-chd and others added 11 commits June 25, 2026 19:03
Currently translated at 100.0% (3 of 3 strings)

Translation: pos-19.0/pos-19.0-pos_partner_birthdate
Translate-URL: https://translation.odoo-community.org/projects/pos-19-0/pos-19-0-pos_partner_birthdate/de/
Currently translated at 100.0% (16 of 16 strings)

Translation: pos-19.0/pos-19.0-pos_edit_order_line
Translate-URL: https://translation.odoo-community.org/projects/pos-19-0/pos-19-0-pos_edit_order_line/de/
This module inhibits the manipulation that the point of sale mades over
the sales orders pickings, and the creation of new pickings under the
PoS picking type.

Use Cases / Context
===================

In some scenarios, you may not want that the point of sale (PoS) handles
the pickings of the products you are paying:

- Using the PoS as a pure payment terminal.
- When complex stock flows are not supplied by the PoS.

In that cases, it's better to keep the original sales pickings.
Currently translated at 100.0% (3 of 3 strings)

Translation: pos-18.0/pos-18.0-pos_sale_picking_keep
Translate-URL: https://translation.odoo-community.org/projects/pos-18-0/pos-18-0-pos_sale_picking_keep/it/
If you have previously sync a `pos.order` (for example, because you have
gone to backend with an opened order), and later you do things like
unlinking an existing line, you may find other kind of commands in
`lines` dictionary like `(2, <id>)`, making the code of this module to
crash, so let's protect it properly.
@jarsabot

Copy link
Copy Markdown
    **WARNING**: Could not link to Odoo task. Record ID not found in the title of the MR, supported formats:
{ record type }#{ number }

Available types: 'task#', 't#' (case insensitive)

Examples:

  • task#123

  • i#123

- Bump manifest version to 19.0.1.0.0.
- Add sale_stock dependency: pos_sale loads sale.order.picking_ids in the
  PoS data, a field provided by sale_stock. It is auto_install so it is
  normally present, but it is not pulled in the minimal CI install, which
  made the PoS fail to load with 'Invalid field picking_ids on sale.order'.
  The module also operates on the sale order stock moves/pickings, so the
  dependency is required.
- Update the PoS test tour imports to the new 19.0 paths
  (tests/pos/tours/utils and generic_helpers).
- Grant the sales user group in tests, as point_of_sale.group_pos_manager
  no longer implies sales rights and the onchange now checks create access.
- Use f-strings for the tour URLs (ruff UP031).
- Add CONTRIBUTORS and regenerate README.
@alan196 alan196 force-pushed the 19.0-mig-pos_sale_picking_keep branch from 3fae09a to c262e7f Compare June 27, 2026 13:15
@jarsabot

Copy link
Copy Markdown
    **WARNING**: Could not link to Odoo task. Record ID not found in the title of the MR, supported formats:
{ record type }#{ number }

Available types: 'task#', 't#' (case insensitive)

Examples:

  • task#123

  • i#123

1 similar comment
@jarsabot

Copy link
Copy Markdown
    **WARNING**: Could not link to Odoo task. Record ID not found in the title of the MR, supported formats:
{ record type }#{ number }

Available types: 'task#', 't#' (case insensitive)

Examples:

  • task#123

  • i#123

@alan196 alan196 merged commit 91e12b5 into Jarsa:19.0 Jun 27, 2026
2 of 4 checks passed
@jarsabot

Copy link
Copy Markdown
    **WARNING**: Could not link to Odoo task. Record ID not found in the title of the MR, supported formats:
{ record type }#{ number }

Available types: 'task#', 't#' (case insensitive)

Examples:

  • task#123

  • i#123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants