feat: add inverse_transform toggle - #25
Open
bllyanos wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a flag to disable
inverse_transformfor environments where it behaves incorrectly (notably sway). The default behavior remains unchanged, but users can now opt out of the inverse transform path to keep the rest of the transform logic working reliably.Context
On my sway setup,
inverse_transformproduces incorrect results, which breaks the overall transformation flow.Why this change
inverse_transformis broken on a compositor.inverse_transformworks correctly.Behavior
inverse_transformstays enabled.Testing