Skip to content

fix(ci): publish agama-inbound jar so the auth-server image can build#14228

Merged
moabu merged 1 commit into
mainfrom
ci/publish-agama-inbound-asset
Jun 7, 2026
Merged

fix(ci): publish agama-inbound jar so the auth-server image can build#14228
moabu merged 1 commit into
mainfrom
ci/publish-agama-inbound-asset

Conversation

@mo-auto

@mo-auto mo-auto commented Jun 7, 2026

Copy link
Copy Markdown
Member

Summary

docker-jans-auth-server pulls casa-config, jans-fido2-client, jans-fido2-model and agama-inbound as custom libs from the GitHub release, but build-test.yml only collected the first three. So agama-inbound-0.0.0-nightly.jar is 404 on the release and the docker (auth-server) image build fails (e.g. run 27098512184, even with all WARs present), leaving a stale/broken ghcr.io/.../auth-server image.

agama-inbound is a jans-auth-server submodule (jans-auth-server/agama/inboundID, artifactId agama-inbound), installed to ~/.m2 during the auth-server deploy. This adds it to the release-asset collection alongside the other auth-server custom libs.

Why a standalone PR

Broken out of #14225 (the integration-test work that surfaced this) so it can merge ahead of the next scheduled nightly — otherwise the nightly Build and Publish Releases to Hub keeps failing the auth-server image build.

Verification

  • agama-inbound builds into ~/.m2/repository/io/jans/agama-inbound/0.0.0-nightly/ during the jans-auth-server deploy (already in the module matrix).
  • After this lands, the next nightly publishes agama-inbound-0.0.0-nightly.jar and the docker (auth-server) build's custom-libs loop resolves it.

Summary by CodeRabbit

  • Chores
    • Updated release artifacts collection to include additional JAR binaries in release builds, ensuring expanded release asset availability.

docker-jans-auth-server pulls casa-config + jans-fido2-client + jans-fido2-model +
agama-inbound as custom libs from the release, but build-test only collected the first three,
so agama-inbound-0.0.0-nightly.jar was 404 and the 'docker (auth-server)' image build failed
(run 27098512184) - leaving a stale ghcr auth-server image (and breaking the AIO jans-auth).

agama-inbound is a jans-auth-server submodule (jans-auth-server/agama/inboundID, artifactId
agama-inbound), installed to ~/.m2 during the auth-server deploy; add it to the release-asset
collection alongside the other auth-server custom libs.

Signed-off-by: moauto <54212639+mo-auto@users.noreply.github.com>
@mo-auto mo-auto requested a review from moabu as a code owner June 7, 2026 19:37
@mo-auto

mo-auto commented Jun 7, 2026

Copy link
Copy Markdown
Member Author

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3799437b-1f71-446c-bab3-3116a3d71d16

📥 Commits

Reviewing files that changed from the base of the PR and between f002abc and 856c795.

📒 Files selected for processing (1)
  • .github/workflows/build-test.yml

📝 Walkthrough

Walkthrough

The build-test workflow's release binary collection step is extended to copy agama-inbound-${VERSION}.jar files from the Maven repository into the temporary release artifacts directory. The comment describing the collected artifacts is updated to document the inclusion of these agama-inbound jars for auth-server custom libraries.

Changes

Release Binary Collection Update

Layer / File(s) Summary
Agama-inbound binary collection
.github/workflows/build-test.yml
The release binary collection step extends its find pattern to match agama-inbound-${VERSION}.jar files from the Maven repository, and the descriptive comment is updated to reflect that fido2/casa-config artifacts now include agama-inbound jars for auth-server custom libraries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

area-CI

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description addresses the target issue context and implementation details comprehensively, but does not follow the required template structure with explicit sections or checkboxes as specified in the repository's description_template. Restructure the description to match the required template format: include Target issue section with issue link, Implementation Details section, and Test and Document checkboxes section.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding the agama-inbound jar to CI publishing so the auth-server Docker image can build successfully.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/publish-agama-inbound-asset

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mo-auto mo-auto added area-CI Issue or changes required in automatic builds or CI infrastructure kind-bug Issue or PR is a bug in existing functionality labels Jun 7, 2026
@moabu moabu merged commit feed511 into main Jun 7, 2026
3 checks passed
@moabu moabu deleted the ci/publish-agama-inbound-asset branch June 7, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CI Issue or changes required in automatic builds or CI infrastructure kind-bug Issue or PR is a bug in existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants