fix(ci): publish agama-inbound jar so the auth-server image can build#14228
Conversation
docker-jans-auth-server pulls casa-config + jans-fido2-client + jans-fido2-model + agama-inbound as custom libs from the release, but build-test only collected the first three, so agama-inbound-0.0.0-nightly.jar was 404 and the 'docker (auth-server)' image build failed (run 27098512184) - leaving a stale ghcr auth-server image (and breaking the AIO jans-auth). agama-inbound is a jans-auth-server submodule (jans-auth-server/agama/inboundID, artifactId agama-inbound), installed to ~/.m2 during the auth-server deploy; add it to the release-asset collection alongside the other auth-server custom libs. Signed-off-by: moauto <54212639+mo-auto@users.noreply.github.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe build-test workflow's release binary collection step is extended to copy ChangesRelease Binary Collection Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
docker-jans-auth-serverpullscasa-config,jans-fido2-client,jans-fido2-modelandagama-inboundas custom libs from the GitHub release, butbuild-test.ymlonly collected the first three. Soagama-inbound-0.0.0-nightly.jaris 404 on the release and thedocker (auth-server)image build fails (e.g. run 27098512184, even with all WARs present), leaving a stale/brokenghcr.io/.../auth-serverimage.agama-inboundis ajans-auth-serversubmodule (jans-auth-server/agama/inboundID, artifactIdagama-inbound), installed to~/.m2during the auth-server deploy. This adds it to the release-asset collection alongside the other auth-server custom libs.Why a standalone PR
Broken out of #14225 (the integration-test work that surfaced this) so it can merge ahead of the next scheduled nightly — otherwise the nightly
Build and Publish Releases to Hubkeeps failing the auth-server image build.Verification
agama-inboundbuilds into~/.m2/repository/io/jans/agama-inbound/0.0.0-nightly/during thejans-auth-serverdeploy (already in the module matrix).agama-inbound-0.0.0-nightly.jarand thedocker (auth-server)build's custom-libs loop resolves it.Summary by CodeRabbit