Skip to content

feat: port a11y-architect agent + accessibility skill from upstream - #46

Merged
Jamkris merged 1 commit into
mainfrom
feat/upstream-sync-2026-04
Apr 27, 2026
Merged

feat: port a11y-architect agent + accessibility skill from upstream#46
Jamkris merged 1 commit into
mainfrom
feat/upstream-sync-2026-04

Conversation

@Jamkris

@Jamkris Jamkris commented Apr 27, 2026

Copy link
Copy Markdown
Owner

Summary

Ports two clean additions from everything-claude-code (upstream as of 4e66b28) that fit the Gemini CLI extension scope without rewriting:

Larger upstream items (gateguard hook + skill, bash dispatcher, Python LLM provider layer, Rust core, plugin manifests) are intentionally not included — they are deeply Claude-Code-protocol-coupled or out of scope for a Gemini CLI extension. PR 2 in this sync wave will cover block-no-verify.js and validate-workflow-security.js.

Frontmatter migration (a11y-architect)

Before (upstream) After (this PR)
model: sonnet + model: opus (duplicate, schema-forbidden) removed (Gemini CLI agent schema does not accept model)
tools: [Read, Write, Edit, Bash, Grep, Glob] tools: [read_file, write_file, replace, run_shell_command, search_file_content, glob]
Body content unchanged — no Claude-specific references

The migration is the exact mapping enforced by scripts/lib/gemini-tools.js (Phase 2 SoT).

Test plan

  • node scripts/ci/validate-agents.js — 48 agents validated (was 47)
  • node scripts/ci/validate-skills.js — 183 skill directories validated (was 182)
  • npm run lint — clean
  • npm test — 165/165 pass
  • Reviewer spot-check that the agent's tool list still makes sense for an accessibility audit workflow

Summary by CodeRabbit

  • Documentation
    • Added new accessibility agent guidance for designing WCAG 2.2 Level AA compliant interfaces
    • Included comprehensive skill documentation covering semantic mapping, focus management, and cross-platform labeling standards for Web, iOS, and Android
    • Provided best practices, anti-patterns, and implementation examples for accessible components

Adopts two upstream additions from everything-claude-code (commits up to
4e66b28) that fit the Gemini CLI extension scope cleanly.

agents/a11y-architect.md
  - WCAG 2.2 accessibility architect for Web/iOS/Android UI work
  - Frontmatter migrated to Gemini CLI shape:
      removed duplicate `model:` lines (forbidden by our schema)
      Read/Write/Edit/Bash/Grep/Glob → read_file/write_file/replace/
      run_shell_command/search_file_content/glob
  - Body unchanged (no Claude-specific references)
  - Passes scripts/ci/validate-agents.js (Phase 2 strict validator)

skills/accessibility/SKILL.md
  - WCAG 2.2 implementation patterns for Web (ARIA), iOS (SwiftUI),
    Android (Compose), with cross-platform mapping table
  - Copied as-is — no Claude-specific content; frontmatter already
    matches our format (`name`, `description`, `## When to Use`)

Lint clean / 165 tests pass / 48 agents + 183 skills validated.
@coderabbitai

coderabbitai Bot commented Apr 27, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 762beb3c-4452-459d-8496-a04c2a2a4cf9

📥 Commits

Reviewing files that changed from the base of the PR and between 67146be and e325ee0.

📒 Files selected for processing (2)
  • agents/a11y-architect.md
  • skills/accessibility/SKILL.md

Walkthrough

Adds two accessibility documentation files: an AI agent prompt for accessibility architecture guidance following WCAG 2.2 Level AA, and a comprehensive skill guide covering inclusive design principles, platform-specific attribute mapping, and best-practices for Web, iOS, and Android.

Changes

Cohort / File(s) Summary
Accessibility Documentation
agents/a11y-architect.md, skills/accessibility/SKILL.md
New agent prompt and skill documentation covering WCAG 2.2 Level AA compliance, inclusive UI design, focus management, target sizing, cross-platform accessibility attributes, code examples, anti-patterns, and best-practices checklist.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~10 minutes

Suggested labels

agents, skills

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: porting two accessibility-related files (a11y-architect agent and accessibility skill) from upstream, which aligns with the file additions and PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/upstream-sync-2026-04

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Jamkris
Jamkris merged commit a8b9739 into main Apr 27, 2026
8 checks passed
@Jamkris Jamkris added the ✨ Feature New feature or improvement request label Apr 27, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Jun 20, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Feature New feature or improvement request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant