Fix CI (deterministic allowlist test) + reset version to 1.0.0 - #1
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 4 files
You're on the cubic free plan with 19 free PR reviews remaining this month. Upgrade for unlimited reviews.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_allowlist_nftset_mode_shows_setupdeterministic by forcing the "set not found" lookup, instead of relying on hownftfails in CI (was green locally on py3.9, red on CI py3.12).Test plan
python -m pytest -q→ 92 passed locally.Summary by cubic
Fix CI by making the nftset allowlist setup test deterministic across Python 3.10/3.12. Reset
bastionversion to 1.0.0 for the initial public release and condense the CHANGELOG to a single 1.0.0 entry.test_allowlist_nftset_mode_shows_setupdeterministic by forcing nftset prefs and a “set not found” result via monkeypatch, removing reliance onnftbehavior in CI.Written for commit 7279baa. Summary will update on new commits.