Add SCREAMING-case symlinks for the debug CRT libs#176
Open
RyanJamesStewart wants to merge 1 commit into
Open
Conversation
xwin splat --include-debug-libs did not create the uppercase symlinks for libcmtd/msvcrtd, so a case-sensitive linker fails to open LIBCMTD.lib under /MTd or MSVCRTD.lib under /MDd. Extract the curated alias match into angry_crt_alias so it can carry a regression test, and add the two debug-variant arms. Fixes Jake-Shadle#166
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xwin splat --include-debug-libsdoesn't create the uppercase symlinks for the debug CRT libraries, so a case-sensitive linker fails to find them.src/splat.rscurates the SCREAMING-case aliases for the CRT libs referenced via uppercase/DEFAULTLIBdirectives (libcmt->LIBCMT.lib,msvcrt->MSVCRT.lib,oldnames->OLDNAMES.lib). This covers the release runtimes (/MT,/MD) but not their debug twins: under/MTdthe static debug CRT islibcmtd.lib, under/MDdthe dynamic debug CRT ismsvcrtd.lib. Both miss every arm and get no alias, so on a case-sensitive filesystemlld-linkcannot openLIBCMTD.lib(#166).This adds the two debug-variant arms (
oldnameshas no debug variant). The match is pulled into a smallangry_crt_aliasfunction so it can carry a regression test, since no existing test setsinclude_debug_libs.cargo fmt --all -- --check,cargo clippy --lib, and the new test all pass.Fixes #166.