Adding the ability to select a custom SC2Hotkeys file#6
Open
syfogidas wants to merge 12 commits into
Open
Conversation
temporary hack: 6.0 core trial under Standard menu item
hack 6.0 trial under lite menu item
prototype using custom hotkey file (no error handling)
custom hotkey progress
attempt at fixing scope issues
revert and remove renderContainer call
add to dropdown without renderContainer
revert temporary hack of lite
revert temporary hack of standard
Try moving to a better location
oops
make sure it runs after site renders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The visualizer has long been outdated, because the core version(s) included are obsolete.
Instead of just including any given current version, I added the ability of the user to provide their own SC2Hotkeys file to visualize.
(of course LoTV units are still missing etc.)