Feature/react styleguidist#5
Conversation
for now need to run unit test using npm test global jest has issues with the imports for some reason
| this.down = this.down.bind(this); | ||
| this.up = this.up.bind(this); | ||
| this.keyCodeMaps = { | ||
| 27: 'ESC', |
There was a problem hiding this comment.
The quoting here looks odd to me but probably just work; though, I'd say is definitely something stylistic to consider.
There was a problem hiding this comment.
do you mean you would like " " better ?
i usually use for stings ' ' just because i like to do " " for the values inside the html/ jsx
But like you said both would work.
I think i will look into what formatter we could add to the pre commit. So that at least everything is consisted throughout the project
There was a problem hiding this comment.
Sorry it didn't show what I was meaning very well but if you look down a bit lines (+22 to +31) suddenly the keys and values are both double quoted and then further down it goes back to the keys being unquoted and the values being single quoted. I know JS likes to be a bit loose with typing but I wanted to make sure I pointed it out in case it could cause issues.
As a few side notes. I usually stick to single quotes in JS and as for a style checker I recently used https://eslint.org/ and wasn't horribly disappointed.
There was a problem hiding this comment.
ok i just changed the strings so that we use ' when possible.
The only strings that will always be "incorrect"
will be '"' and "'"
|
I don't really like adding only adrenal glads to the icons file to make that one example work. It feels kinda tacked on to what is otherwise just adding styleguidist? |
|
yeah i was thinking about only adding styleguidist. but to make sure that there are not issues i added the small sample. |
3 participants
Should be great to see what components we have to make contributing even easier.