Skip to content

Feature/jest unit tests#4

Open
Anzumana wants to merge 4 commits into
JaKaTaK:gh-pagesfrom
Anzumana:feature/jest-unit-tests
Open

Feature/jest unit tests#4
Anzumana wants to merge 4 commits into
JaKaTaK:gh-pagesfrom
Anzumana:feature/jest-unit-tests

Conversation

@Anzumana

Copy link
Copy Markdown

Enabled the ability to write unit tests so we can make sure that pr's can be merge.
If you have some time we could set up circle ci or travis ci to run them.

@Troto

Troto commented Oct 31, 2019

Copy link
Copy Markdown

In the last jest unit tests commit, shouldn't there be a package.json as well as the lock file? I'm not super familiar with using npm but I thought you usually updated through the non locked file?

@Anzumana

Anzumana commented Nov 1, 2019

Copy link
Copy Markdown
Author

Hey, so usually you can commit both to the repo. The package lock file ensures that if someone is just trying out the feature. They don't run into any bugs due to differences in the specific version of the dependencies that were installed.

npm recommends to commit it.
https://docs.npmjs.com/files/package-lock.json
This file is intended to be committed into source repositories,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants