Feature/jest unit tests#4
Open
Anzumana wants to merge 4 commits into
Open
Conversation
for now need to run unit test using npm test global jest has issues with the imports for some reason
|
In the last jest unit tests commit, shouldn't there be a package.json as well as the lock file? I'm not super familiar with using npm but I thought you usually updated through the non locked file? |
Author
|
Hey, so usually you can commit both to the repo. The package lock file ensures that if someone is just trying out the feature. They don't run into any bugs due to differences in the specific version of the dependencies that were installed. npm recommends to commit it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabled the ability to write unit tests so we can make sure that pr's can be merge.
If you have some time we could set up circle ci or travis ci to run them.