ci: wire coco-dev-versions and import-specifier checks into the workflow - #9894
ci: wire coco-dev-versions and import-specifier checks into the workflow#9894bitfathers94 wants to merge 1 commit into
Conversation
Both checks live in `test:ci` but no GitHub Actions job ran either, so each could silently diverge with zero CI signal -- the same local-only-until-now gap the surrounding drift steps close. Add a named `coco-dev-versions:check` step gated on a new `cocoDev` path filter (k8s/coco-dev/**, scripts/check-coco-dev-versions*.ts) plus the push clause, and a named `import-specifiers:check` step gated on backend or any packages/* workspace filter (mcp/engine/miner/ discoveryIndex), mirroring the checker's BUNDLER_ROOTS/NODENEXT_ROOTS. Also add a real-tree regression assertion to the import-specifier test so the guard is enforced by vitest, not the workflow step alone -- the gap that let two specifier drifts reach main after the guard shipped.
|
Caution 🛑 LoopOver review result - reject/close recommendedReview updated: 2026-07-29 19:46:24 UTC
Review summary Blockers
Nits — 4 non-blocking
Why this is blocked
📋 Copy for AI agents — paste into your coding agentDecision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9894 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 921 921
Lines 113175 113175
Branches 27245 27245
=======================================
Hits 103856 103856
Misses 8034 8034
Partials 1285 1285
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
LoopOver is closing this pull request on the maintainer's behalf (AI review flagged a likely critical defect: validate-code's job-level `if:` was not updated to include `needs.changes.outputs.cocoDev`, so a PR touching only k8s/coco-dev/** skips the entire job and the new 'Coco-dev versions drift check' step never runs on that PR despite its own step-level gate.). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
ci: wire coco-dev-versions and import-specifier checks into the workflow
Both checks live in
test:cibut no GitHub Actions job ran either, soeach could silently diverge with zero CI signal -- the same
local-only-until-now gap the surrounding drift steps close.
Add a named
coco-dev-versions:checkstep gated on a newcocoDevpath filter (k8s/coco-dev/**, scripts/check-coco-dev-versions*.ts) plus
the push clause, and a named
import-specifiers:checkstep gated onbackend or any packages/* workspace filter (mcp/engine/miner/
discoveryIndex), mirroring the checker's BUNDLER_ROOTS/NODENEXT_ROOTS.
Also add a real-tree regression assertion to the import-specifier test
so the guard is enforced by vitest, not the workflow step alone -- the
gap that let two specifier drifts reach main after the guard shipped.
Closes #9649