miner(attempt): close the AttemptCliResult and RunAttemptOptions .d.ts drifts - #9888
Conversation
…s drifts Add a blocked_max_concurrent_claims variant to the AttemptCliResult union carrying the reason/maxConcurrentClaims/activeClaimCount fields the cap-race blockedResult builds, and drop the as-cast plus drift comment on its onResult call. Declare loadReputationHistory on RunAttemptOptions beside the other resolver seams and remove the inline cast that read it off the options object. Runtime is unchanged: same emitted fields, same exit code 11, same options.loadReputationHistory ?? loadReputationHistory resolution order.
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-29 19:05:32 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9888 +/- ##
==========================================
+ Coverage 79.28% 79.38% +0.10%
==========================================
Files 281 282 +1
Lines 58510 58801 +291
Branches 6777 6874 +97
==========================================
+ Hits 46387 46678 +291
Misses 11840 11840
Partials 283 283
Flags with carried forward coverage won't be shown. Click here to find out more.
|
miner(attempt): close the AttemptCliResult and RunAttemptOptions .d.ts drifts
Add a blocked_max_concurrent_claims variant to the AttemptCliResult union
carrying the reason/maxConcurrentClaims/activeClaimCount fields the cap-race
blockedResult builds, and drop the as-cast plus drift comment on its onResult
call. Declare loadReputationHistory on RunAttemptOptions beside the other
resolver seams and remove the inline cast that read it off the options object.
Runtime is unchanged: same emitted fields, same exit code 11, same
options.loadReputationHistory ?? loadReputationHistory resolution order.
Closes #9685