Skip to content

miner(attempt): close the AttemptCliResult and RunAttemptOptions .d.ts drifts - #9888

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
bitfathers94:fix/issue-9685
Jul 29, 2026
Merged

miner(attempt): close the AttemptCliResult and RunAttemptOptions .d.ts drifts#9888
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
bitfathers94:fix/issue-9685

Conversation

@bitfathers94

Copy link
Copy Markdown
Contributor

miner(attempt): close the AttemptCliResult and RunAttemptOptions .d.ts drifts

Add a blocked_max_concurrent_claims variant to the AttemptCliResult union
carrying the reason/maxConcurrentClaims/activeClaimCount fields the cap-race
blockedResult builds, and drop the as-cast plus drift comment on its onResult
call. Declare loadReputationHistory on RunAttemptOptions beside the other
resolver seams and remove the inline cast that read it off the options object.

Runtime is unchanged: same emitted fields, same exit code 11, same
options.loadReputationHistory ?? loadReputationHistory resolution order.

Closes #9685

…s drifts

Add a blocked_max_concurrent_claims variant to the AttemptCliResult union
carrying the reason/maxConcurrentClaims/activeClaimCount fields the cap-race
blockedResult builds, and drop the as-cast plus drift comment on its onResult
call. Declare loadReputationHistory on RunAttemptOptions beside the other
resolver seams and remove the inline cast that read it off the options object.

Runtime is unchanged: same emitted fields, same exit code 11, same
options.loadReputationHistory ?? loadReputationHistory resolution order.
@bitfathers94
bitfathers94 requested a review from JSONbored as a code owner July 29, 2026 18:59
@loopover-orb

loopover-orb Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Warning

⏸️ LoopOver review result - manual review recommended

Review updated: 2026-07-29 19:05:32 UTC

2 files · 1 AI reviewer · no blockers · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This PR closes two documented .d.ts drift comments in attempt-cli.ts: adding the blocked_max_concurrent_claims member to the AttemptCliResult union (matching the exact blockedResult shape built at runAttempt's cap-race block) and declaring loadReputationHistory on RunAttemptOptions, then removing the two inline `as`-casts that previously bridged those drifts. The diff is narrow, well-targeted at the acknowledged gaps, and the tests directly guard both changes: a compile-time assignability check for the new union member and a plain (uncast) RunAttemptOptions object using loadReputationHistory, plus a runtime test asserting exit code 11 and the onResult payload shape. Runtime behavior is unchanged per the description, and the diff confirms this — the resolution order and emitted fields are identical, only the type declarations and casts changed.

Nits — 3 non-blocking

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #9685
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 94 registered-repo PR(s), 65 merged, 1 issue(s).
Contributor context ✅ Confirmed Gittensor contributor bitfathers94; Gittensor profile; 94 PR(s), 1 issue(s).
Improvement ✅ Minor risk: clean · value: minor · LLM: minor
Linked issue satisfaction

Addressed
The diff adds the blocked_max_concurrent_claims variant to AttemptCliResult with the exact required fields, removes the onResult cast and its drift comment, declares loadReputationHistory on RunAttemptOptions beside the other seams with a matching doc comment, and removes the inline cast/comment while preserving the same resolution order and exit code 11.

Review context
  • Author: bitfathers94
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is registered but has no active allocation in the current snapshot.
  • Public profile languages: TypeScript
  • Official Gittensor activity: 94 PR(s), 1 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Await review-lane availability.
  • Then work through the remaining 1 step in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 29, 2026
@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.38%. Comparing base (3bee8cc) to head (7173c87).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9888      +/-   ##
==========================================
+ Coverage   79.28%   79.38%   +0.10%     
==========================================
  Files         281      282       +1     
  Lines       58510    58801     +291     
  Branches     6777     6874      +97     
==========================================
+ Hits        46387    46678     +291     
  Misses      11840    11840              
  Partials      283      283              
Flag Coverage Δ
backend 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/loopover-miner/lib/attempt-cli.ts 100.00% <100.00%> (ø)

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit f9008bc into JSONbored:main Jul 29, 2026
8 checks passed
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

miner(attempt): close the two acknowledged .d.ts drifts in AttemptCliResult and RunAttemptOptions

1 participant