mcp(stdio): restore the CurrentBranchInput narrowing on the eight local-branch tools - #10257
Conversation
…al-branch tools LocalBranchAnalysisInput widened login/repoFullName to required so the remote server (no checkout) could advertise the full vocabulary, but the eight stdio registrations of that contract never narrowed back down -- so the stdio server advertised and enforced the same required fields the remote does, even though its handlers resolve both from the active session and the checkout. Declares a StdioLocalBranchAnalysisInput/StdioDraftPrBodyInput narrowing derived from the contract (mirroring StdioMarkNotificationsReadInput) and wires it into the eight registerStdioTool call sites via the existing input override seam.
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-31 14:49:02 UTC
Review summary Nits — 6 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10257 +/- ##
==========================================
- Coverage 80.60% 78.67% -1.94%
==========================================
Files 283 285 +2
Lines 59101 61356 +2255
Branches 7000 7827 +827
==========================================
+ Hits 47641 48271 +630
- Misses 11167 12662 +1495
- Partials 293 423 +130
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mcp(stdio): restore the CurrentBranchInput narrowing on the eight local-branch tools
LocalBranchAnalysisInput widened login/repoFullName to required so the remote
server (no checkout) could advertise the full vocabulary, but the eight stdio
registrations of that contract never narrowed back down -- so the stdio server
advertised and enforced the same required fields the remote does, even though
its handlers resolve both from the active session and the checkout. Declares a
StdioLocalBranchAnalysisInput/StdioDraftPrBodyInput narrowing derived from the
contract (mirroring StdioMarkNotificationsReadInput) and wires it into the
eight registerStdioTool call sites via the existing input override seam.
Closes #10034