fix(miner): keep discover --dry-run off the contribution-profile cache - #10255
Conversation
JSONbored#10000) Thread caller env into the profile-cache path and skip open/put on dry-run when the SQLite file is missing, matching the event-ledger zero-write guard. Co-authored-by: Cursor <cursoragent@cursor.com>
…ed#10000) Give the vi.fn two parameters so mock.calls[0][1] is a valid tuple index under root typecheck. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-31 14:37:13 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10255 +/- ##
===========================================
- Coverage 92.25% 80.67% -11.59%
===========================================
Files 938 284 -654
Lines 114702 59362 -55340
Branches 27698 7097 -20601
===========================================
- Hits 105821 47889 -57932
- Misses 7575 11168 +3593
+ Partials 1306 305 -1001
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Closes #10000
Summary
Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragenpm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderate