fix(miner): give manage-status and manage-poll store openers their own try/catch - #10206
Conversation
…n try/catch runManageStatus and runManagePoll opened their SQLite stores before any try/finally, so an opener throw became an unhandled exception (exit 1 instead of the documented 2) and leaked any sibling store already opened. Mirror runDiscover's pattern: each opener gets its own try/catch that returns a clean CLI failure and closes whichever owned handles were already opened.
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-31 12:52:45 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
1 similar comment
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10206 +/- ##
==========================================
+ Coverage 80.44% 80.52% +0.07%
==========================================
Files 282 284 +2
Lines 58764 58988 +224
Branches 6965 7052 +87
==========================================
+ Hits 47274 47498 +224
Misses 11199 11199
Partials 291 291
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fix(miner): give manage-status and manage-poll store openers their own try/catch
runManageStatus and runManagePoll opened their SQLite stores before any
try/finally, so an opener throw became an unhandled exception (exit 1
instead of the documented 2) and leaked any sibling store already opened.
Mirror runDiscover's pattern: each opener gets its own try/catch that
returns a clean CLI failure and closes whichever owned handles were
already opened.
Closes #10003