fix(upstream): treat a failed drift-issue fingerprint search as inconclusive, not absent

[bitfathers94]

fix(upstream): treat a failed drift-issue fingerprint search as inconclusive, not absent

Both the recorded-issue fast path and the fingerprint-search fallback returned null for a
read failure (non-OK response, thrown fetch) exactly as they did for a genuine no-match, so a
transient GitHub rate-limit or 5xx during the drift reconcile fell straight through to filing
a brand-new issue for a fingerprint that may already have one. Both lookups now return an
{ existing, errored } pair (mirroring LastCloserResult.errored) so the caller can tell "found
nothing" apart from "learned nothing" and skip instead of creating a duplicate on the errored
path, leaving the report's stored issue reference untouched. The fingerprint-search pagination
walk is also bounded to 10 pages, matching every other list walk in this file, with an
exhausted cap now treated as a read failure rather than proof no issue exists.

Closes #10027

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-31 09:17:54 UTC}

2 files · 1 AI reviewer · no blockers · readiness 93/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This PR correctly closes the read-failure/no-match ambiguity in the drift-issue lookup path: validateRecordedGitHubIssue and findGitHubIssueForFingerprint now return {existing, errored} pairs, fileUpstreamDriftIssues ORs the two errored flags and skips (leaving the report's stored issue reference untouched) instead of falling through to createGitHubDriftIssue on a transient rate-limit/5xx/thrown-fetch/exhausted-page-cap. The fingerprint search is also bounded to 10 pages (FINGERPRINT_SEARCH_PAGE_LIMIT), matching the file's existing pagination conventions, and an exhausted cap is now treated as a read failure rather than a false 'not found'. Tests are thorough and exercise both arms of the new errored/existing tuple, page-2 failure, and the 10-page cap, and all cited call sites match the full file content shown.

Nits — 5 non-blocking

• `src/upstream/ruleset.ts:1088-1114` — the new `DriftIssueLookupResult` type and doc comment are dense; consider trimming the comment now that the shape is self-explanatory from its two fields.
• The long block comment inline in `fileUpstreamDriftIssues` (src/upstream/ruleset.ts:350-357) restates what the type-level comment on `DriftIssueLookupResult` already says — could be deduped to one location.
• `FINGERPRINT_SEARCH_PAGE_LIMIT` mirrors other per-file page caps (COMMENT_SEARCH_PAGE_LIMIT etc.) but each is defined locally rather than shared — minor DRY opportunity, not blocking for this change.
• Consider extracting a shared `GITHUB_LIST_PAGE_LIMIT` constant across the file's several page-capped walks instead of one per function, per the nit above.
• The regression tests are well-targeted; no changes needed there.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#10027
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	⚠️ 20/25	Preflight is ready, but the PR body does not name the validation run.
Contributor workload	✅ 10/10	Author activity: 119 registered-repo PR(s), 82 merged, 3 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	bitfathers94; Gittensor profile; 119 PR(s), 3 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The diff implements the required three-state result shape ({existing, errored}) for both validateRecordedGitHubIssue and findGitHubIssueForFingerprint, makes fileUpstreamDriftIssues skip-and-continue on any errored lookup without touching stored issue references, and adds a named FINGERPRINT_SEARCH_PAGE_LIMIT=10 constant that treats an exhausted cap as a read failure rather than 'no match', matchi

Review context

• Author: bitfathers94
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: TypeScript
• Official Gittensor activity: 119 PR(s), 3 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Start here: Add validation command/output.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.11%. Comparing base (32c5f27) to head (11b1451).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10141      +/-   ##
==========================================
+ Coverage   79.95%   80.11%   +0.15%     
==========================================
  Files         282      283       +1     
  Lines       58728    59224     +496     
  Branches     6930     7107     +177     
==========================================
+ Hits        46958    47447     +489     
  Misses      11480    11480              
- Partials      290      297       +7     

Flag	Coverage Δ
backend	98.58% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/upstream/ruleset.ts	98.58% <100.00%> (ø)

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.