ci: add per-PR cross-platform build gate#233
Merged
Merged
Conversation
Build-only workflow that compiles the ssb64 target on Windows, Linux, and macOS for every pull_request and push to main. Mirrors release.yml's desktop jobs (deps incl. Pillow, fetch-depth: 0 for git-describe, Windows Python3_EXECUTABLE pin) minus packaging. Codegen runs via CMake custom targets, so no manual presteps. ROM-independent end-to-end. Catches platform-specific build breaks (e.g. Windows-only mod loaders) before review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
.github/workflows/build.yml— a build-only CI workflow that compiles thessb64target on Windows (MSVC), Linux (clang), and macOS (arm64) for everypull_requestand push tomain.Why
Today the only workflow is
release.yml, which runs solely onv*tags. No check verifies that a contribution even compiles across platforms before review or merge — a maintainer has to build it by hand on three machines to find out. That's a real gap with active cross-platform work in flight (e.g. a mod loader using a Windows-only detour primitive would pass review and silently break the macOS arm64 release target).This gate catches that automatically, in red, on the PR.
Design
BattleShip.o2r. Likerelease.yml, it's ROM-independent end-to-end, so it's safe for public CI.release.yml's desktop jobs minus packaging, so a green run here predicts a green release build:find_packagedeps (libzip, nlohmann_json, tinyxml2, spdlog, SDL2, GLEW) + Pillow for the unconditional CSS scroll-arrow codegen.fetch-depth: 0so the updater'sgit describe --tagsresolves at configure time.Python3_EXECUTABLEis pinned to the samepythonthat pip installed Pillow under, avoiding the multi-interpreter "Pillow is required" failure.concurrencycancels superseded runs on the same ref to save runner minutes.Notes for review
usversion only (default). Theus/jpmatrix inrelease.ymlis release-scoped; a single region is enough to catch compile breakage.mainonly. Easy to adjust.