The Game Component Refactor - #4
Merged
Merged
Conversation
Yes, I could break this into more components, but it is already a simple component.
Added a PageHeader component for all pages to use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I've interacted with thoughtfully-designed components in other projects, I have realized that my components are messy. This refactor evaluates all components in game. They won't be perfect, but this will be a step in the right direction. The idea is that Game.tsx` is the root of the game component tree, and any children that need to modify other state within the game should use callbacks to do so.
I also added a new component:
PageHeader, so each page is consistent, and there is no more code duplication for the header.