Skip to content

PR for #172 upgrade github actions checkout version#173

Merged
arewolinski merged 1 commit into
mainfrom
172-github-action-check-failed-silently-due-to-deprecated-library
Jul 8, 2026
Merged

PR for #172 upgrade github actions checkout version#173
arewolinski merged 1 commit into
mainfrom
172-github-action-check-failed-silently-due-to-deprecated-library

Conversation

@zhizhongpu

Copy link
Copy Markdown
Collaborator

No description provided.

@zhizhongpu zhizhongpu linked an issue Jun 26, 2026 that may be closed by this pull request
@zhizhongpu

Copy link
Copy Markdown
Collaborator Author

@jmshapir please suggest reviewers

/run-actions-issue --post

@github-actions

This comment was marked as low quality.

@jmshapir jmshapir requested a review from arewolinski June 27, 2026 17:43
@zhizhongpu zhizhongpu self-assigned this Jun 28, 2026
@toogiii

toogiii commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

/run-actions-issue --post

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Triggered by @toogiii on this comment

Check Results (run details)

Check Result Time
SCons DAG SKIP
Newlines SKIP
EPS data SKIP
Log failures SKIP

@arewolinski

Copy link
Copy Markdown
Collaborator

/run-actions-all --post

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Triggered by @arewolinski on this comment

Check Results (run details)

Check Result Time
SCons DAG 0.038s
Newlines 0.046s
EPS data 0.027s
Log failures 0.032s

@arewolinski

Copy link
Copy Markdown
Collaborator

/run-actions-issue --post

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Triggered by @arewolinski on this comment

Check Results (run details)

Check Result Time
SCons DAG SKIP
Newlines SKIP
EPS data SKIP
Log failures SKIP

@arewolinski arewolinski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding, this is an upgrade that helps us run the github actions workflow effectively. From my reading online, v6 is the new up-to-date version that we should be using, so this change makes sense! Approved!

If @jmshapir would like, I could merge this change in (I know previously @jmshapir mentioned potentially getting @zhizhongpu to merge it in, so if that would be preferred just let me know). I don't think it should be difficult since the code barely changed.

@jmshapir

jmshapir commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@arewolinski I think it's fine for you to merge thanks.

@arewolinski

arewolinski commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Great, I will get that done.

@arewolinski

Copy link
Copy Markdown
Collaborator

@jmshapir I don't believe I have write permissions to the Template. Would you be able to grant these permissions so that I can merge this branch?

@jmshapir

jmshapir commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@arewolinski done thanks!

@arewolinski arewolinski assigned arewolinski and unassigned zhizhongpu Jul 8, 2026
@arewolinski arewolinski merged commit 77f44b8 into main Jul 8, 2026
19 checks passed
@arewolinski arewolinski deleted the 172-github-action-check-failed-silently-due-to-deprecated-library branch July 8, 2026 21:12
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

@arewolinski Issue summary

Thanks for closing this pull.

Before leaving the pull, please be sure you have completed all the required steps in the workflow.

This includes filling in the issue summary linked at the top of this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub Action check failed silently due to deprecated library

4 participants