Changing the variable names to match changes to surface variable names - #590
Merged
Conversation
rajichidamb
requested review from
BenjaminRuston,
ClaraDraper-NOAA and
guoqing-noaa
July 30, 2026 16:00
guoqing-noaa
approved these changes
Jul 30, 2026
3 tasks
BenjaminRuston
added
ready for merge
jcsda-bot
pushed a commit
to JCSDA/mpas-jedi
that referenced
this pull request
Aug 4, 2026
## Description ``` mpasjedi_3dvar........................................................................failed mpasjedi_3dvar_2pe....................................................................failed Exception stack: UserError: airTemperature is specified as a simulated variable but it has not been specified as an observed or a derived variable. ``` To fix this failure updating the yaml to use new file with both variables airTemperature and airTemperatureAt2M ## Issue(s) addressed Resolves JCSDA-internal/ufo#4181 ## Dependencies build-group=JCSDA-internal/ufo-data#590 build-group=JCSDA-internal/ufo#4251 List the other PRs that this PR is dependent on: - [ ] JCSDA-internal/ufo-data#590 - [ ] JCSDA-internal/ufo#4251 ## Impact Expected impact on downstream repositories: ## Manual Testing Instructions (optional) If you would like your reviewers to manually build and test the change, please include instructions on how the change should be built and tested. Also include a short justification on why manual testing is necessary for this change. ## Checklist - [X] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation - [X] I have run the unit tests before creating the PR --------- Co-authored-by: BenjaminRuston <benr@ucar.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
virtualTemperature changed to virtualTemperatureAt2M and
airTemperature changed to airTemperatureAt2M
Issue(s) addressed
Resolves https://github.com/JCSDA-internal/ufo/issues/4269
build-group=https://github.com/JCSDA-internal/ufo/pull/4251
build-group=https://github.com/JCSDA-internal/mpas-jedi/pull/1227
Dependencies
List the other PRs that this PR is dependent on:
Impact
Expected impact on downstream repositories:
Manual Testing Instructions (optional)
If you would like your reviewers to manually build and test the change, please include
instructions on how the change should be built and tested. Also include a short
justification on why manual testing is necessary for this change.
Checklist