Skip to content

Fix soca builds #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shlyaeva merged 2 commits into from
Jul 11, 2026
Merged

Fix soca builds #1250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
769cca3
Fix missing include
fmahebert Jul 10, 2026
fe99b4c
Use floating-point abs
fmahebert Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/soca/SaberBlocks/ParametricOceanStdDev/ParametricOceanStdDev.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* which can be obtained at http://www.apache.org/licenses/LICENSE-2.0.
*/

#include <cmath>

#include "oops/util/Logger.h"
#include "oops/util/Timer.h"

Expand Down Expand Up @@ -144,7 +146,7 @@ ParametricOceanStdDev::ParametricOceanStdDev(
double sstVal = v_sstErr(i, 0);
for (size_t z = 0; z < levels; z++) {
// step 1: calc value from dT/dz
auto val = abs(tocnParams.dz.value() * v_dtdz(i, z));
auto val = std::abs(tocnParams.dz.value() * v_dtdz(i, z));

// step 2: calc a min from the e-folding scale, and min SST value
auto localMin = minVal + (sstVal - minVal) * exp(-v_depth(i, z) / efold);
Expand Down
1 change: 1 addition & 0 deletions src/soca/Utils/OceanSmoother.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include "oops/base/GeometryData.h"
#include "oops/generic/Diffusion.h"
#include "oops/util/FieldSetHelpers.h"
#include "oops/util/Logger.h"

#include "soca/Utils/OceanSmoother.h"

Expand Down
Loading