This repository was archived by the owner on Apr 12, 2023. It is now read-only.
Set can_issue_permission to organizations by default - #56
Open
Khukhunashvili wants to merge 1 commit into
Open
Conversation
aashutoshrathi
approved these changes
Dec 5, 2018
aashutoshrathi
left a comment
aashutoshrathi
left a comment
Collaborator
There was a problem hiding this comment.
Yeah, we needed it bad.
Thanks @khukhuna
jatinkatyal13
left a comment
jatinkatyal13
left a comment
Collaborator
There was a problem hiding this comment.
Nice work! But can't we handle this in the model rather than serializers?
Collaborator
|
@khukhuna We might need a rebase buddy 😅 |
aashutoshrathi
suggested changes
Dec 19, 2018
Khukhunashvili
commented
Dec 19, 2018
aashutoshrathi
left a comment
aashutoshrathi
left a comment
Collaborator
There was a problem hiding this comment.
Things look better now, just check the comment.
And try creating a student locally.
Squash all your commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, I'm working on GCI task where I have to issue a certificates, but when I log in as organization & send post request to
/api/issue_certificate, it responds with message:You do not have permission to perform this action., so this (Giving 'can_issue_certificate' permission' to organization by default) should fix the problem.please let me know if I'm missing something & there is a way to get this permission.