Added Feature for Login using OAuth - #48
Conversation
jatinkatyal13
left a comment
jatinkatyal13
left a comment
There was a problem hiding this comment.
Checkout the comments !
|
Let's talk about the flow now! |
aashutoshrathi
left a comment
aashutoshrathi
left a comment
There was a problem hiding this comment.
Hi, @saivittalb
I will review this tomorrow properly.
But for now I have left a comment on the line, I'm confused with.
And also make sure you PEP8ify all your changes 😄
Thanks that's a lot of nice work in one PR. 🚀
|
I have corrected my code in reference to @aashutoshrathi's comment and also used PEP8 to test locally with the above environment! |
aashutoshrathi
left a comment
aashutoshrathi
left a comment
There was a problem hiding this comment.
Check comments that I have left.
aashutoshrathi
left a comment
aashutoshrathi
left a comment
There was a problem hiding this comment.
Good to go, we just have to run it properly.
| 'FACEBOOK_SECRET', | ||
| 'TWITTER_KEY', | ||
| 'TWITTER_SECRET']: | ||
| exec("{key} = os.environ.get('{key}', '')".format(key=key)) |
There was a problem hiding this comment.
instead os.environ.get use config
There was a problem hiding this comment.
config is already imported in the class from decouple
I changed the os.environ.get to config
aashutoshrathi
left a comment
aashutoshrathi
left a comment
There was a problem hiding this comment.
Update env vars and add social_django to requirements and Pipfile
aashutoshrathi
left a comment
aashutoshrathi
left a comment
There was a problem hiding this comment.
Apart from changes requested, do an AutoPEP8 operation
| TWITTER_SECRET=YOUR-SECRET-KEY | ||
| ALLOWED_HOSTS=.localhost, .herokuapp.com | ||
| DEBUG= | ||
| DEBUG= No newline at end of file |
| pytz==2018.5 | ||
| whitenoise==4.1 | ||
| psycopg2-binary | ||
| social_django |
There was a problem hiding this comment.
Change this to social-auth-app-django
There was a problem hiding this comment.
Done ✅ Also did an AutoPEP8 operation 👍
| @@ -1,25 +1,31 @@ | |||
| language: python | |||
| python: | |||
| - 3.6 | |||
There was a problem hiding this comment.
Revert indentation changes in this file
| pytz == 2018.5 | ||
| whitenoise == 4.1 | ||
| psycopg2 - binary | ||
| social-auth-app-django |
There was a problem hiding this comment.
Revert indentation changes here too.
3 participants
Implemented Feature for Login using OAuth2 🎉
If any change is required, please let me know! 😃