This repository was archived by the owner on Apr 12, 2023. It is now read-only.
JWT authentication for users and cert issuers - #33
Open
junron wants to merge 8 commits into
Open
Conversation
jatinkatyal13
suggested changes
Nov 9, 2018
jatinkatyal13
left a comment
jatinkatyal13
left a comment
Collaborator
There was a problem hiding this comment.
Convert the view to CreateAPIView! other then that awesome work 🚀
junron
changed the title
Contributor
Author
|
I've fixed the changes requested |
Contributor
Author
|
Would appreciate if @jatinkatyal13 or @aashutoshrathi could review my PR, thanks |
jatinkatyal13
left a comment
jatinkatyal13
left a comment
Collaborator
There was a problem hiding this comment.
Nice Work ! These two changes would make this PR perfect !
Contributor
Author
|
Hi, @jatinkatyal13 and @aashutoshrathi could you have a look again |
Collaborator
|
Awesome 🚀 |
jatinkatyal13
approved these changes
Nov 11, 2018
aashutoshrathi
suggested changes
Nov 11, 2018
aashutoshrathi
left a comment
aashutoshrathi
left a comment
Collaborator
There was a problem hiding this comment.
Just resolve these ones and we are GTG
| def test(self): | ||
| # Run tests in correct order | ||
| self.create_cert_student_user() | ||
| self.authenticate_cert_student_user() No newline at end of file |
Collaborator
There was a problem hiding this comment.
Add newline and make sure you are following PEP8
Contributor
Author
There was a problem hiding this comment.
Added newline and split some lines to keep within 79 character limit
jatinkatyal13
suggested changes
Nov 11, 2018
aashutoshrathi
approved these changes
Nov 11, 2018
jatinkatyal13
approved these changes
Nov 11, 2018
Collaborator
|
Awesome work now you can submit the task on code-in dashboard 🚀 |
Contributor
Author
|
I forgot about that 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCI task