This repository was archived by the owner on Apr 12, 2023. It is now read-only.
Added Logout Feature - #298
Open
sayyss wants to merge 1 commit into
Open
Conversation
anshumanv
approved these changes
Dec 21, 2019
anshumanv
left a comment
anshumanv
left a comment
There was a problem hiding this comment.
Thanks for your work! You didn't have to open a new PR, you can amend the old PR by adding subsequent commits. LGTM
| constructor(private router: Router) { } | ||
|
|
||
| // Check if User is Logged In | ||
| isLoggedin(){ |
There was a problem hiding this comment.
Hi! Thanks for going with the suggested approach, you can further simplify this in future like
isLoggedIn() {
return localStorage.getItem('token') !== null
}
But this works totally fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check by changing each
[ ]to[x]Please take note of the white-space as it matters.Description / Changes
Added Logout Feature
Screenshots
Youtube - Link