✨ Implement JFC drive mapping refactor with comprehensive test suite#105
Merged
Conversation
Replaces usrlogon.bat with modern PowerShell implementation for 30 JFC locations. Features: - Automatic site code detection from computer name - Terminal server detection and skipping (TRM, ACT, ACP suffixes) - Persistent drive mapping for U:, W:, and S: (where applicable) - IP-based servers for JOH (10.70.1.1) and JPH (10.30.1.1) - Custom group shares per location (JOH_groups, Groups_JPH, JDL_groups) - Comprehensive verbose logging for troubleshooting - Graceful error handling with detailed messages
Validates all 54 test cases covering: - Basic execution and verbose output handling - Site code detection for all 30 JFC locations - Terminal server detection (TRM, ACT, ACP suffixes) - Server configuration assignments - Group share naming conventions - S: drive mapping for special locations - Full execution path for all 30 active JFC sites All tests passing with proper error handling validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements the complete JFC drive mapping refactor by converting location-specific batch scripts into a unified PowerShell solution. This PR adds:
Why are we doing this?
How should this be tested?
.\Invoke-DriveMapping.ps1 -VerboseAny deployment notes?
Closes #84