Fix WebDAV saves not visible after relaunch (#338)#354
Open
MohandL3G wants to merge 1 commit into
Open
Conversation
Root cause: BackupMenuState::initialize_remote_storage compared PROPFIND response parent IDs (full server-relative paths like /remote.php/dav/files/user/JKSV/) against internal m_parent (short config-basepath paths like /JKSV/). The mismatch caused directory_exists to always return false on relaunch, so either a new empty directory was created (MKCOL 201) or initialization returned early (MKCOL 405), making previously uploaded saves invisible or scattering uploads to root. Fix WebDav::process_listing to use the queried path as parentID instead of extracting it from XML hrefs. Build normalized item IDs from parentID + escaped name, matching the format produced by create_directory()/upload_file(). Also fixes recursive PROPFIND URL construction which previously doubled the path by appending the full href to the origin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the WebDAV issue from here #338 (comment)
This is what OpenCode wrote: