Skip to content

Fix join line scripts not handling Windows CRLF line endings #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tathagat22 wants to merge 148 commits into
base: master
Choose a base branch
from

Fix join line scripts not handling Windows CRLF line endings (fixes #…

01100be
Select commit
Loading
Failed to load commit list.
Open

Fix join line scripts not handling Windows CRLF line endings #402

Fix join line scripts not handling Windows CRLF line endings (fixes #…
01100be
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded May 4, 2026 in 32s

Quality Gate passed

Issues
66 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 21 in Boop/Boop/scripts/BinaryToDecimal.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.isNaN` over `isNaN`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrjKYbFk4hZjN2m5&open=AZ30wrjKYbFk4hZjN2m5&pullRequest=402

Check warning on line 13 in Scripts/JoinLines.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrN-YbFk4hZjN2mP&open=AZ30wrN-YbFk4hZjN2mP&pullRequest=402

Check warning on line 20 in Boop/Boop/scripts/SortJSON.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Handle this exception or don't catch it at all. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrW7YbFk4hZjN2mn&open=AZ30wrW7YbFk4hZjN2mn&pullRequest=402

Check warning on line 22 in Boop/Boop/scripts/hex2rgb.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrp2YbFk4hZjN2nC&open=AZ30wrp2YbFk4hZjN2nC&pullRequest=402

Check warning on line 20 in Boop/Boop/scripts/DecimalToHex.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.isNaN` over `isNaN`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrncYbFk4hZjN2m-&open=AZ30wrncYbFk4hZjN2m-&pullRequest=402

Check warning on line 27 in Scripts/rgb2hex.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Handle this exception or don't catch it at all. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrT6YbFk4hZjN2mZ&open=AZ30wrT6YbFk4hZjN2mZ&pullRequest=402

Check warning on line 21 in Boop/Boop/scripts/DecimalToBinary.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.isNaN` over `isNaN`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrf2YbFk4hZjN2m1&open=AZ30wrf2YbFk4hZjN2m1&pullRequest=402

Check warning on line 19 in Scripts/FromUnicode.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String.fromCodePoint()` over `String.fromCharCode()`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrP_YbFk4hZjN2mT&open=AZ30wrP_YbFk4hZjN2mT&pullRequest=402

Check warning on line 21 in Scripts/toUnicode.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`String.raw` should be used to avoid escaping `\`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrVYYbFk4hZjN2mg&open=AZ30wrVYYbFk4hZjN2mg&pullRequest=402

Check warning on line 16 in Scripts/WktToWkb.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrUfYbFk4hZjN2ma&open=AZ30wrUfYbFk4hZjN2ma&pullRequest=402

Check warning on line 16 in Boop/Boop/scripts/URLRefang.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wreZYbFk4hZjN2mx&open=AZ30wreZYbFk4hZjN2mx&pullRequest=402

Check warning on line 14 in Boop/Boop/scripts/URLDefang.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrrFYbFk4hZjN2nF&open=AZ30wrrFYbFk4hZjN2nF&pullRequest=402

Check warning on line 18 in Boop/Boop/scripts/URLEntitiesEncode.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#codePointAt()` over `String#charCodeAt()`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrdJYbFk4hZjN2mr&open=AZ30wrdJYbFk4hZjN2mr&pullRequest=402

Check warning on line 26 in Scripts/convertToMarkdownTable.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#codePointAt()` over `String#charCodeAt()`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrJ-YbFk4hZjN2mM&open=AZ30wrJ-YbFk4hZjN2mM&pullRequest=402

Check warning on line 18 in Boop/Boop/scripts/URLEntitiesEncode.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrdJYbFk4hZjN2mq&open=AZ30wrdJYbFk4hZjN2mq&pullRequest=402

Check warning on line 16 in Boop/Boop/scripts/URLDefang.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrrFYbFk4hZjN2nH&open=AZ30wrrFYbFk4hZjN2nH&pullRequest=402

Check warning on line 16 in Scripts/convertToMarkdownTable.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrJ-YbFk4hZjN2mL&open=AZ30wrJ-YbFk4hZjN2mL&pullRequest=402

Check warning on line 151 in Scripts/WkbToWkt.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not call `Array#push()` multiple times. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrWbYbFk4hZjN2mk&open=AZ30wrWbYbFk4hZjN2mk&pullRequest=402

Check warning on line 181 in Scripts/WktToWkb.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.isNaN` over `isNaN`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrUfYbFk4hZjN2md&open=AZ30wrUfYbFk4hZjN2md&pullRequest=402

Check warning on line 14 in Scripts/JoinLinesWithSpace.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrHYYbFk4hZjN2mJ&open=AZ30wrHYYbFk4hZjN2mJ&pullRequest=402

Check warning on line 19 in Scripts/toUnicode.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#codePointAt()` over `String#charCodeAt()`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrVYYbFk4hZjN2mf&open=AZ30wrVYYbFk4hZjN2mf&pullRequest=402

Check warning on line 16 in Scripts/convertToMarkdownTable.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrJ-YbFk4hZjN2mK&open=AZ30wrJ-YbFk4hZjN2mK&pullRequest=402

Check warning on line 29 in Boop/Boop/scripts/SortJSON.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid using `instanceof` for type checking as it can lead to unreliable results. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrW7YbFk4hZjN2mo&open=AZ30wrW7YbFk4hZjN2mo&pullRequest=402

Check warning on line 22 in Scripts/rgb2hex.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrT6YbFk4hZjN2mY&open=AZ30wrT6YbFk4hZjN2mY&pullRequest=402

Check warning on line 19 in Boop/Boop/scripts/BinaryToDecimal.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=IvanMathy_Boop&issues=AZ30wrjKYbFk4hZjN2m4&open=AZ30wrjKYbFk4hZjN2m4&pullRequest=402
View more details on SonarQubeCloud