Enforce sync_paths allowlist for write, rename, and delete operations - #19
Open
mikaelweave wants to merge 3 commits into
Open
Enforce sync_paths allowlist for write, rename, and delete operations#19mikaelweave wants to merge 3 commits into
mikaelweave wants to merge 3 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ce92f992-712e-47b2-a98a-4b268f67db3a
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b72c9df1-26d9-48ba-b15f-b075f2d8eb95
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b72c9df1-26d9-48ba-b15f-b075f2d8eb95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
When
sync_pathsis configured, enforce it for every local filesystem operation that can affect iCloud:Operations outside the allowlisted paths should fail with an appropriate filesystem error such as
EACCESorEPERM.For rename and move operations, both the source and destination paths should be allowed.
exclude_pathsshould continue to take precedence oversync_paths.Testing