Fix iCloud upload failure: make NamedFileStream pass requests' file c… - #14
Open
Micha2 wants to merge 1 commit into
Open
Fix iCloud upload failure: make NamedFileStream pass requests' file c…#14Micha2 wants to merge 1 commit into
Micha2 wants to merge 1 commit into
Conversation
…heck NamedFileStream exposed read() only through __getattr__. requests' _encode_files detects readable file objects with isinstance(fp, _SupportsRead), a runtime_checkable Protocol that, on Python 3.12+, inspects the class rather than going through __getattr__. The wrapper therefore failed the check, so requests treated it as raw data and passed the object straight to urllib3's body.write(), raising "a bytes-like object is required, not 'NamedFileStream'". Define read() explicitly so the stream satisfies the protocol check, while keeping the wrapper so the uploaded file gets the correct basename instead of the full local mirror path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NamedFileStream exposed read() only through getattr. requests' _encode_files detects readable file objects with
isinstance(fp, _SupportsRead), a runtime_checkable Protocol that, on Python 3.12+, inspects the class rather than going through getattr. The wrapper therefore failed the check, so requests treated it as raw data and passed the object straight to urllib3's body.write(), raising "a bytes-like object is required, not 'NamedFileStream'".
Define read() explicitly so the stream satisfies the protocol check, while keeping the wrapper so the uploaded file gets the correct basename instead of the full local mirror path.