[pull] main from perplexityai:main#13
Merged
Merged
Conversation
- BIND_ADDRESS defaults to 127.0.0.1 (was 0.0.0.0) - ALLOWED_ORIGINS defaults to empty (was "*") - Add ALLOWED_HOSTS for Host header allowlisting - Reject Origin: null unless explicitly allowlisted - Log a warning at startup when BIND_ADDRESS=0.0.0.0 or ALLOWED_ORIGINS=* - Rename :public scripts to :UNSAFE-public to make config visible - Add SECURITY.md and configuration notes - Refactor http.ts to export createHttpApp() for testability - Add regression tests for CORS, Origin: null, and Host allowlist
…or disallowed Origin - Startup banners (BIND_ADDRESS=0.0.0.0, ALLOWED_ORIGINS=*, listening banner) now write directly to stderr instead of going through the level-gated logger, which defaults to ERROR. Without this, the banners were silently dropped under default config. - Disallowed cross-origin preflights now return 403 with a JSON-RPC error body instead of the default Express 500. Mirrors the 421 emitted by the Host header check. - Tests: 3 new banner tests (spy on console.error); existing CORS rejection tests upgraded to assert 403 + JSON-RPC body.
chore(http): tighten default config for HTTP transport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )