Skip to content

Fix Darwin MIDI port direction mapping #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mortenboye merged 3 commits into from
Jul 30, 2026
Merged

Fix Darwin MIDI port direction mapping #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2585b57
Update BLE test fakes for Universal BLE connect config
mortenboye Jul 28, 2026
2c9ca64
Merge branch 'master' into fix-darwin-midi-port-direction-164
mortenboye Jul 28, 2026
51a1d87
merge fix
mortenboye Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## NEXT

- FIX(darwin): report CoreMIDI destinations as `inputPorts` and sources as `outputPorts` so port direction matches Android and the public device-owned API contract (#164).
- FIX(android): disable Kotlin incremental compilation for the Android implementation so Windows builds do not fail when the app project and Pub cache are on different drives (#163).

## 1.0.7
Expand Down
9 changes: 5 additions & 4 deletions packages/flutter_midi_command_ble/test/flutter_midi_command_ble_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,10 +400,11 @@ void main() {

test('connectToDevice makes registered known BLE device visible', () async {
fakePlatform.servicesByDevice['ble-known-connect'] = midiServices();
final registered = transport.registerKnownDevice(
'ble-known-connect',
'Known Connect Device',
)!;
final registered =
transport.registerKnownDevice(
'ble-known-connect',
'Known Connect Device',
)!;

expect(await transport.devices, isEmpty);

Expand Down