SigId validation#55
Open
coot wants to merge 8 commits into
Open
Conversation
coot
force-pushed
the
coot/sig-id
branch
2 times, most recently
from
0ded8bf to
f58205a
Compare
Contributor
crocodile-dentist
left a comment
crocodile-dentist
left a comment
There was a problem hiding this comment.
Just two comments
Comment on lines
+159
to
+160
| when (a /= 5) $ fail (printf "decodeSig: unexpected number of parameters %d for Sig" a) | ||
| sigRawId <- decodeSigId |
Contributor
There was a problem hiding this comment.
Do we need a new NodeToNode version if we're changing the codec?
Contributor
Author
There was a problem hiding this comment.
We do, but with @jpraynaud we decided to just break the dmq-node (it's not yet in production).
The encoding is changed according to: cardano-foundation/CIPs#1185
* log sigids of `MsgReplySigIds` * log sigids of `MsgRequestSigs` using JSON syntax
It is not needed, since we use the new tracing system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes
Checklist