Conversation
Bumps [coverage](https://github.com/coveragepy/coveragepy) from 7.13.1 to 7.13.4. - [Release notes](https://github.com/coveragepy/coveragepy/releases) - [Changelog](https://github.com/coveragepy/coveragepy/blob/main/CHANGES.rst) - [Commits](coveragepy/coveragepy@7.13.1...7.13.4) --- updated-dependencies: - dependency-name: coverage dependency-version: 7.13.4 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the pip group with 1 update in the / directory: [pytest](https://github.com/pytest-dev/pytest). Updates `pytest` from 9.0.2 to 9.0.3 - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@9.0.2...9.0.3) --- updated-dependencies: - dependency-name: pytest dependency-version: 9.0.3 dependency-type: direct:development dependency-group: pip ... Signed-off-by: dependabot[bot] <support@github.com>
Bump pytest from 9.0.2 to 9.0.3 in the pip group across 1 directory
Bump coverage from 7.13.1 to 7.13.4
* ignore AI agents md files
* Issue:The `__escape_dict` and `__escape_list` methods silently drop legitimate falsy values (like `0` or `False`) because they check `elif value:` instead of `elif value is not None:`.
Fix:** Update the conditionals to explicitly check for `None`.
* fix dns_sec and domain:pw tags
* fix fail to read the full payload if data arrives in multiple chunks. use sendall instead of send to make sure all the data is sent.
The `get_format_32()` function is unnecessary as `struct.calcsize(">I")` is guaranteed to be 4 bytes in Python.
* Increase the version to 0.2.0
* bump the dependencies
* if the peer closed the connection mid-response, will return none
* Change the unit test to reflect using sendall instead of send
* Updated the dictionary comprehension that filters keyword arguments to use value is not None instead of a simple truthiness check (if value). This ensures that 0 and False are not filtered out of the parameters passed to the XML template.
* Update unit tests to refelct dns sec changes in the template
* Update docstring and types to reflect the recent changes
* Add more unit test to increase the coverage to %100
* Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* fix test_data_to_dict unit test
* Update documentions
---------
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and bug fixes across the PyEPP codebase, focusing on enhanced DNSSEC handling, improved template rendering, better falsy value support, and documentation updates. The changes ensure more robust and flexible EPP command generation, especially for DNSSEC data, and improve the reliability of socket communications. Additionally, the CLI and documentation have been updated for clarity and accuracy.
DNSSEC and Command Rendering Improvements
dns_sec) records, allowing a list of DS records to be rendered correctly in the EPP XML. This is now thoroughly tested with new unit tests for both single and multipledns_secscenarios. [1] [2] [3]command_templates.py) where the closing tag fordomain:pwwas incorrect.Falsy Value Handling
0andFalsein command parameters and escaping routines, ensuring they are not inadvertently dropped. Corresponding tests were added to ensure this behavior. [1] [2] [3] [4] [5]Socket Communication Robustness
epp.pyto usesendall(ensuring all bytes are sent), handle empty chunks gracefully, and clarify type hints for optional returns. [1] [2] [3]">I"format.Documentation and CLI Enhancements
pollCLI command and improved various documentation typos and examples, including correct usage of DNSSEC lists and imports in the usage example. [1] [2] [3] [4] [5]Other Updates
0.2.0and updated development dependencies to their latest versions. [1] [2]base_command.py. [1] [2]These changes collectively enhance PyEPP's reliability, flexibility, and usability for both developers and end users.