fix(stream): usage on finalChatCompletion, fence-strip in .text, APIUserAbortError on abort#11
Merged
Merged
Conversation
…xt, raise APIUserAbortError on abort - finalChatCompletion() now captures the streamed usage chunk (empty choices) + system_fingerprint, read before the choice early-return, and includes them in the result. - .text getter applies the json_object fence strip (stripFence), matching #build(); previously finalChatCompletion() content was unfenced but stream.text still returned the ```json fence. - Aborting mid-stream now throws APIUserAbortError (consistent with non-streaming) instead of ending silently, so a truncated/aborted stream is distinguishable from a completed one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three streaming bugs in
src/stream.ts:finalChatCompletion()droppedusage. The streamed usage chunk (emptychoices, populatedusage) was skipped by#accumulate'sif (!choice) return. Nowusage+system_fingerprintare read before the choice check and included in the result (mirrors interfaze-python's fix)..textgetter didn't strip the json_object fence. Same stream gave two answers —finalChatCompletion()content was{"a":1}butstream.textreturned the ```json-fenced form.stripFencewas applied in `#build()` but not the getter; now both strip.AbortController.abort()during iteration just ended the stream — no error — so truncated content looked final. Now iterating (orfinalChatCompletion()/textDeltas()) throwsAPIUserAbortErrorwhen the signal is aborted, consistent with the non-streaming path.Tests added for all three; full suite 52 passing, typecheck + build clean.