fix(cli): register graph scan as a subcommand of the graph group (#644)#699
Open
bstevenski-capillary wants to merge 4 commits into
Open
fix(cli): register graph scan as a subcommand of the graph group (#644)#699bstevenski-capillary wants to merge 4 commits into
bstevenski-capillary wants to merge 4 commits into
Conversation
#644) The scan command was promoted to a top-level `harness scan` command via the barrel generator's EXTRA_TOP_LEVEL_COMMANDS list, while the post-update hook, fallback hints, and docs all referenced `harness graph scan`. As a result `harness graph scan` failed with 'unknown command scan' while the stale top-level `harness scan` still resolved — exactly the confusion reported. - Remove graph/scan.ts from EXTRA_TOP_LEVEL_COMMANDS and regenerate _registry - Add scan as a subcommand of the graph group in graph/index.ts - Update all user-facing 'harness scan' hints to 'harness graph scan' across CLI messages, MCP tools, dashboard gather modules, core checklist, and guides - Update graph + impact-preview tests for the new wiring/strings Note: local pre-commit arch check fails on pre-existing baseline drift on main (module-size 54340->167219 etc.) in files untouched here; verified identical on pristine main with these changes stashed. Baseline is bot-refreshed post-merge.
# Conflicts: # docs/reference/cli-commands.md # packages/cli/src/commands/graph/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #644.
The root cause was the inverse of the issue's literal framing.
scanwas wired as a top-levelharness scancommand — promoted via the barrel generator'sEXTRA_TOP_LEVEL_COMMANDSlist — while the post-update hook (update.ts), the fallback hints, and the docs all referencedharness graph scan. Thegraphcommand group only registeredstatusandexport. As a result:harness graph scan .→error: unknown command 'scan'(the exact error reported)harness scan→ still resolved (top-level), which is why the reporter saw it "succeed" — not a stale binary, just the misplaced registrationChanges
graph/scan.tsfromEXTRA_TOP_LEVEL_COMMANDSinscripts/generate-barrel-exports.mjsand regenerated_registry.ts, soharness scanis no longer a top-level command and the fix survives barrel regeneration.scanas a subcommand of thegraphgroup ingraph/index.ts.harness scanhints toharness graph scanacross CLI command messages, MCP tools, dashboard gather modules, the core review checklist, and the currentdocs/guides/*.md. Regenerateddocs/reference/cli-commands.md. Left untouched:harness scan-config(a different, real command), historicaldocs/changes/**, and the ADR.graph.test.tsnow assertsscanis agraphsubcommand; updated theimpact-previewassertion string; added a changeset (cli/core/dashboard patch).Verification
harness graph --helplistsscan;harness scannow returnsunknown command 'scan'