Remove mypy#566
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
Author
|
Looks like mypy is still wired into the setup via tests - I had noted that it isn't a separate CI step, which is true, but there's some unusual indirection going on. I'll think on this a bit, my instinct is that it's not worth having two type checkers, but I don't have strong opinions |
Collaborator
|
You just need to remove the call to mypy from the makefile here: https://github.com/Instagram/Fixit/blob/main/makefile#L28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't believe mypy is actually used - at this point we type check with Pyrefly