Skip to content

Fail fast for system SWIG 4.4+ with Python limited API #6544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SID-6921 wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −0
Open

Fail fast for system SWIG 4.4+ with Python limited API #6544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions Wrapping/Generators/SwigInterface/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,23 @@ if(ITK_USE_SYSTEM_SWIG)
"Swig version less than ${swig_version_min}: \"${SWIG_VERSION}\". Set ITK_USE_SYSTEM_SWIG=OFF or provide a newer swig."
)
endif()

# Known-broken combination: system SWIG 4.4+ with Python Limited API emits
# wrappers that fail at import time (missing delete_SwigPyIterator on moduledef).
if(
ITK_WRAP_PYTHON
AND
ITK_USE_PYTHON_LIMITED_API
AND
SWIG_VERSION
VERSION_GREATER_EQUAL
4.4.0
)
message(
FATAL_ERROR
"System SWIG ${SWIG_VERSION} with ITK_USE_PYTHON_LIMITED_API=ON is currently unsupported due to import-time wrapper failures. Use system SWIG 4.3.x, set ITK_USE_PYTHON_LIMITED_API=OFF, or set ITK_USE_SYSTEM_SWIG=OFF."
)
endif()
elseif(swig_prebuilt)
# Download and extract the prebuilt swig binary at configure time via
# FetchContent so SWIG_EXECUTABLE exists immediately and can be verified.
Expand Down
Loading