Skip to content

feat: add questionnaire details page#1181

Merged
laurentC35 merged 14 commits into
mainfrom
feat/questionnaire-details-subpage
Jul 24, 2026
Merged

feat: add questionnaire details page#1181
laurentC35 merged 14 commits into
mainfrom
feat/questionnaire-details-subpage

Conversation

@MailineN

Copy link
Copy Markdown
Contributor

No description provided.

@MailineN
MailineN requested a review from laurentC35 July 17, 2026 15:18
@MailineN
MailineN marked this pull request as draft July 17, 2026 15:18
@MailineN
MailineN force-pushed the feat/questionnaire-details-subpage branch from cfc033a to 3e5a08a Compare July 17, 2026 15:41
@MailineN
MailineN marked this pull request as ready for review July 17, 2026 15:45
Comment thread next/src/lib/i18n/locales/fr/details.json Outdated
Comment thread next/src/lib/i18n/locales/en/details.json Outdated

@laurentC35 laurentC35 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ergo

  • mettre un champ de type auto-complete pour les series, pour avoir des suggestions, plutôt que chercher dans un longue liste déroulante

Tech

  • invalider la requête get /details lorsque le PUT /details est en succès, car lorsqu'on sort de la page et on revient. On a encore les anciennes valeurs.
  • -> Veux-tu que le back te renvoi les nouveaux details lors du retour du PUT ? (là il y a rien pour le moment)

Comment thread next/src/models/series.ts Outdated
Comment thread next/src/api/utils/questionnaireDetails.ts Outdated
Comment thread next/src/components/details/form/QuestionnaireDetailsForm.tsx Outdated
@MailineN
MailineN requested a review from laurentC35 July 20, 2026 09:12
@MailineN MailineN mentioned this pull request Jul 20, 2026

@laurentC35 laurentC35 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Si on change juste l'operation, le bouton modifier n'est pas cliquable

  • le bouton annuler, renvoi à l'accueil, mais de Pogues ^^

    • sans doute un hard refresh ou rediriger vers la page du questionnaire courant
  • Lorsque le libellé court est non défini (altLabel), affiché "Non défini" en français plutôt qu'undefined

  • pour le agency, c'est ok, on vera plus tard pour avoir la liste déroulante

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@laurentC35
laurentC35 merged commit 3707bcf into main Jul 24, 2026
6 of 7 checks passed
@laurentC35
laurentC35 deleted the feat/questionnaire-details-subpage branch July 24, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants