fix:设置窗口打开时无法与工具栏交互 在任务栏图标中的“退出收纳模式”无效#495
Open
Braydenccc wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates floating bar behavior to keep it visible under certain UI states and changes the settings window from modal to modeless.
Changes:
- Adjust floating bar visibility decisions after margin animations (based on edge proximity / folded state).
- Show the Settings window modeless (
Show) instead of modal (ShowDialog).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2158
to
+2161
| if (MarginFromEdge > 0) | ||
| ViewboxFloatingBar.Visibility = Visibility.Visible; | ||
| else if (!Topmost) | ||
| ViewboxFloatingBar.Visibility = Visibility.Hidden; |
Comment on lines
+2364
to
+2366
| if (!isFloatingBarFolded) | ||
| ViewboxFloatingBar.Visibility = Visibility.Visible; | ||
| else if (!Topmost) ViewboxFloatingBar.Visibility = Visibility.Hidden; |
| _settingsWindow.Topmost = this.Topmost; | ||
| _settingsWindow.Closed += (s, args) => _settingsWindow = null; | ||
| _settingsWindow.ShowDialog(); | ||
| _settingsWindow.Show(); |
doudou0720
reviewed
May 24, 2026
Contributor
Author
|
提交时候似乎有部分修改交错分支了，经测试这个PR也修复了#496所述问题。 |
Braydenccc
changed the title
Member
那请不要重复修复同一个问题 |
Contributor
Author
没有重复，这几个PR混到一个分支里做的，之后拆分commit的时候拆错了（ |
Member
|
请撤销有关.gitignore的修改 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
包括最小化时