-
Notifications
You must be signed in to change notification settings - Fork 10
Bump Injective test tube to v1.20.0 #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jbernal87
wants to merge
3
commits into
dev
Choose a base branch
from
f/v1.20.0
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: InjectiveLabs/test-tube
Length of output: 768
🏁 Script executed:
Repository: InjectiveLabs/test-tube
Length of output: 2034
🌐 Web query:
Rust inline format string syntax minimum supported version requirement💡 Result:
Rust's support for implicit named arguments within format strings (often referred to colloquially as "inline format strings" or f-string-like syntax, such as format!("Hello, {name}")) was stabilized in Rust 1.58.0, released on January 13, 2022 [1][2]. Prior to this version, developers were required to explicitly bind variables if they wanted to use them by name, such as format!("Hello, {name}", name = name). The introduction of this feature allows the macro to implicitly capture local variables with the same name as the identifier provided in the curly braces [3][2]. It is important to note that these are not true "f-strings" in the sense of some other programming languages (which often evaluate arbitrary expressions within the string at runtime). In Rust, the format string must still be a string literal, and the macro operates at compile-time to validate the format string against the provided arguments [4][1]. The feature simply provides syntactic sugar to reduce boilerplate when capturing local variables [3][2]. Subsequent compiler improvements, such as the one implemented in Rust 1.67, further optimized this system by allowing the compiler to flatten or inline literal arguments into the format string during compilation, which can improve performance and help with certain macro-related optimizations [5][6].
Citations:
Declare project MSRV to match Rust 1.58.0+ requirement for inline format syntax.
All four affected files use Rust's inline format string syntax (
{variable}and{variable:?}), which requires Rust 1.58.0 or later. The project currently has no declared MSRV, which creates a compilation compatibility gap. Either addrust-version = "1.58"to the workspace Cargo.toml or revert to explicit format syntax (format!("{}", variable)) for compatibility with earlier Rust versions.Affected files:
packages/injective-test-tube/build.rs:19packages/test-tube/src/runner/app.rs:384packages/test-tube/src/runner/result.rs:242packages/injective-test-tube/src/module/auction.rs:104📍 Affects 4 files
packages/injective-test-tube/build.rs#L19-L19(this comment)packages/test-tube/src/runner/app.rs#L384-L384packages/test-tube/src/runner/result.rs#L242-L242packages/injective-test-tube/src/module/auction.rs#L104-L104🤖 Prompt for AI Agents