Skip to content

docs: add adr for json package#24

Merged
marrip merged 4 commits into
developfrom
23-json-packages
May 26, 2026
Merged

docs: add adr for json package#24
marrip merged 4 commits into
developfrom
23-json-packages

Conversation

@marrip
Copy link
Copy Markdown
Contributor

@marrip marrip commented May 15, 2026

No description provided.

@marrip marrip marked this pull request as draft May 15, 2026 14:34
@marrip marrip marked this pull request as ready for review May 19, 2026 07:30
@marrip marrip self-assigned this May 19, 2026
@danielvo
Copy link
Copy Markdown

Using the json package on LocalApp output in the past was very straightforward but it did take some time. It was nice to see the code examples - the msgspec code was very simple as well. I support the rationale behind the choice here. Thanks for looking into this, Martin! :-)

(Unrelated: Is it just me, or do the result tables and plots in the linked benchmark article show different values?)

Copy link
Copy Markdown
Collaborator

@tinavisnovska tinavisnovska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for looking into this! Can you also add the package into the list of recommended packages in the main readme file of develop?

@marrip
Copy link
Copy Markdown
Contributor Author

marrip commented May 20, 2026

Using the json package on LocalApp output in the past was very straightforward but it did take some time. It was nice to see the code examples - the msgspec code was very simple as well. I support the rationale behind the choice here. Thanks for looking into this, Martin! :-)

(Unrelated: Is it just me, or do the result tables and plots in the linked benchmark article show different values?)

haha, yes, they do, very reliable source then 😜

@marrip
Copy link
Copy Markdown
Contributor Author

marrip commented May 20, 2026

Nice, thanks for looking into this! Can you also add the package into the list of recommended packages in the main readme file of develop?

good point! Done! ✅

@marrip marrip requested a review from calocascio May 20, 2026 14:04
@tinavisnovska
Copy link
Copy Markdown
Collaborator

Nice, thanks for looking into this! Can you also add the package into the list of recommended packages in the main readme file of develop?

good point! Done! ✅

I've realised now that you also want to modify docker files so that the package is installed

@marrip
Copy link
Copy Markdown
Contributor Author

marrip commented May 21, 2026

Nice, thanks for looking into this! Can you also add the package into the list of recommended packages in the main readme file of develop?

good point! Done! ✅

I've realised now that you also want to modify docker files so that the package is installed

yes, will update the deps. And done ✅

@marrip marrip merged commit e8d3e9b into develop May 26, 2026
2 checks passed
@marrip marrip deleted the 23-json-packages branch May 26, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants