fix: replace .max()[0] with .max().iloc[0] for pandas v2.x compatibility#7
Open
takuan517 wants to merge 2 commits into
Open
fix: replace .max()[0] with .max().iloc[0] for pandas v2.x compatibility#7takuan517 wants to merge 2 commits into
takuan517 wants to merge 2 commits into
Conversation
|
Can confirm this fix works. I independently hit the same Heads up — there are also 6 instances of Might be worth including |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a
KeyError: 0crash that occurs across all ML modules when running Planter with pandas >= 2.0.Root Cause
packages.txtspecifiespandas==1.1.3, where.max()[0]happens to work. However, pandas v2.0 removed support for positional integer indexing onSeries, so the following pattern raisesKeyError: 0on modern environments (e.g., Ubuntu 24.04 with Python 3.12):.max()returns aSeriesindexed by column name, not by position.Using
[0]attempts to look up a column named0, which does not exist.Fix
Replace
.max()[0]with.max().iloc[0], which uses explicit positional indexing and is compatible with both pandas v1. x and v2. x.Affected Files
51
table_generator.pyfiles across all ML modules: RF, DT, XGB, SVM, KNN, KM, NN, Bayes, IF, PCA, AutoencoderTested