Make route group prefix optional#280
Merged
viceroypenguin merged 2 commits intoMay 26, 2026
Merged
Conversation
The generated Map{Assembly}{Group}Endpoints method previously required a prefix argument for named route groups; only the default assembly-level group defaulted it to an empty string. Always default prefix to "" so callers can omit it and specify the full route on each handler. Backward-compatible: callers that pass a prefix are unaffected.
eb5a344 to
7bc1ae9
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the route-group registration method generated by Immediate.Apis so that the prefix parameter is optional for named route groups (not just the default assembly-level group), enabling callers to omit the prefix and specify full routes per-handler instead.
Changes:
- Updated the routes template to always emit
prefixwith a default value of"". - Updated
RouteGroupTestsverified snapshots to reflect the new optional parameter for named groups.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Immediate.Apis.Tests/GeneratorTests/RouteGroupTests.ValidRouteGroupTest_groupName=Test123Group#RouteGroupBuilder.Test123Group.g.verified.cs | Snapshot updated: named group route builder now has prefix = "". |
| tests/Immediate.Apis.Tests/GeneratorTests/RouteGroupTests.ValidRouteGroupTest_groupName=Test_Group#RouteGroupBuilder.Test_Group.g.verified.cs | Snapshot updated: named group route builder now has prefix = "". |
| tests/Immediate.Apis.Tests/GeneratorTests/RouteGroupTests.ValidRouteGroupTest_groupName=123TestGroup#RouteGroupBuilder.123TestGroup.g.verified.cs | Snapshot updated: named group route builder now has prefix = "". |
| tests/Immediate.Apis.Tests/GeneratorTests/RouteGroupTests.ValidRouteGroupTest_groupName=_TestGroup#RouteGroupBuilder._TestGroup.g.verified.cs | Snapshot updated: named group route builder now has prefix = "". |
| src/Immediate.Apis.Generators/Templates/Routes.sbntxt | Template updated to always default prefix to "" (making it optional for named groups too). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the
prefixargument of the generated route-group registration method optional.When a handler is decorated with
[RouteGroup("Name")], the generator emits:Previously
prefixwas required for named groups — only the default assembly-level group (Map{Assembly}Endpoints) defaulted it to"". This forces callers to pass a prefix even when they'd rather put the full route on each handler, e.g.:This change always defaults
prefixto""so the argument is optional for named groups too.Backward compatibility
Fully backward-compatible — callers that pass a prefix continue to work unchanged; the prefix simply becomes optional.
Changes
src/Immediate.Apis.Generators/Templates/Routes.sbntxt— always defaultprefixto"".RouteGroupTestsverified snapshots.readme.md— note that the prefix argument is optional.