Skip to content

fix: move Gardiner corridor onto land#5

Open
ImadCreates wants to merge 1 commit into
mainfrom
fix/gta-corridor-coords
Open

fix: move Gardiner corridor onto land#5
ImadCreates wants to merge 1 commit into
mainfrom
fix/gta-corridor-coords

Conversation

@ImadCreates

@ImadCreates ImadCreates commented Jun 28, 2026

Copy link
Copy Markdown
Owner

The Gardiner Expressway corridor in the Phase 2 generator placed its waypoints south of the downtown shoreline, so Haulix 02's interpolated GPS pings rendered in Lake Ontario. Nudges the four Gardiner waypoints north onto the real road alignment and pulls the east end back to the DVP junction. Reviewed all five corridors; only the Gardiner drifted offshore. Regenerated truth.json and haulix.json; VINs and event counts unchanged. All tests and the build pass.

Summary by CodeRabbit

  • Bug Fixes
    • Updated vehicle route and telemetry data for the affected corridor, improving the accuracy of displayed positions, headings, and speeds.
    • Aligned event markers with the revised vehicle path so trip history and incident timing remain consistent.
    • Refined generated route geometry for the corridor to better match the latest expected path.

The Gardiner Expressway corridor in scripts/generate.ts placed its waypoints at latitudes 43.633-43.640, at or south of the downtown harbour shoreline, and its east end at -79.30 (about 2 km offshore off the Beaches). Haulix 02's interpolated GPS pings therefore rendered in Lake Ontario. Nudge the four waypoints north onto the real Gardiner alignment (just south of the CN Tower, ~43.638-43.646 along the waterfront) and pull the east end back to the actual DVP junction (~-79.358). Reviewed all five corridors; the other four (401, 400, QEW, DVP) are inland or north of the lakeshore and were left unchanged. Regenerated truth.json and haulix.json; vehicle registry (VINs) and per-vehicle event counts are unchanged since corridor geometry does not affect the RNG or speed profile.
Copilot AI review requested due to automatic review settings June 28, 2026 19:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f914e928-c033-4915-9043-25a6878cc92e

📥 Commits

Reviewing files that changed from the base of the PR and between 8a9c4cf and c998a97.

📒 Files selected for processing (3)
  • scripts/generate.ts
  • src/data/raw/haulix.json
  • src/data/truth.json

📝 Walkthrough

Walkthrough

The Gardiner Expressway corridor waypoints in scripts/generate.ts are replaced with four new coordinates, and all derived data files (src/data/raw/haulix.json and src/data/truth.json) are regenerated to reflect the updated route geometry for vehicle hx-02 over the 13:20–14:00 window.

Gardiner corridor reroute and hx-02 data regeneration

Layer / File(s) Summary
Gardiner corridor waypoint change
scripts/generate.ts
Replaces the four CORRIDORS.gardiner.points coordinates with a new set, changing the route geometry used during data generation.
Regenerated hx-02 telemetry and events
src/data/raw/haulix.json, src/data/truth.json
Bulk-replaces hx-02 raw latitude/longitude/speed records and canonical locations (with heading) for 13:20–14:00, and updates stored lat/lng on events hx-02-e0 through hx-02-e5.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 Four new points upon the map,
The Gardiner takes a different lap.
hx-02 hops a brand new lane,
New coords flow through each JSON frame.
The rabbit checks each lat and lng—
The route is fresh, the data free! 🗺️

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: moving the Gardiner corridor waypoints onto land.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/gta-corridor-coords

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants