Skip to content

fix(dynamo-gen): robust DateTime/DateTimeOffset check for [UnixTimest…#77

Merged
Im5tu merged 1 commit into
fix/dynamo-unixtimestamp-filteringfrom
fix/pr74-unixtimestamp-typecheck
Jun 17, 2026
Merged

fix(dynamo-gen): robust DateTime/DateTimeOffset check for [UnixTimest…#77
Im5tu merged 1 commit into
fix/dynamo-unixtimestamp-filteringfrom
fix/pr74-unixtimestamp-typecheck

Conversation

@Im5tu

@Im5tu Im5tu commented Jun 17, 2026

Copy link
Copy Markdown
Owner

…amp] filter

Use SpecialType.System_DateTime and a namespace-qualified DateTimeOffset check instead of brittle type.Name comparisons, and only unwrap genuine Nullable (via OriginalDefinition.SpecialType) rather than any generic, so [UnixTimestamp] on List or a custom DateTime type is no longer erroneously accepted. Add nullable DateTime/DateTimeOffset tests.

Checklist

  • Tests added/updated and passing (Docker required for integration tests)
  • Tested to be compatible with Native AOT compilation
  • Documentation updated for new public APIs
  • Self-review completed

…amp] filter

Use SpecialType.System_DateTime and a namespace-qualified DateTimeOffset
check instead of brittle type.Name comparisons, and only unwrap genuine
Nullable<T> (via OriginalDefinition.SpecialType) rather than any generic,
so [UnixTimestamp] on List<DateTime> or a custom DateTime type is no
longer erroneously accepted. Add nullable DateTime/DateTimeOffset tests.
@Im5tu Im5tu merged commit e2b5c8f into fix/dynamo-unixtimestamp-filtering Jun 17, 2026
1 of 2 checks passed
@Im5tu Im5tu deleted the fix/pr74-unixtimestamp-typecheck branch June 17, 2026 13:52
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 43f9d06b-3d45-43be-8e8c-985c88db3c1b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pr74-unixtimestamp-typecheck

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant