docs: correct the issue-close rule — self-run merges do auto-close - #300
Merged
Conversation
"PRs merge via the bot so Closes #n never auto-closes" proved over-broad: a gh pr merge run as a human actor closes linked issues normally (GitHub closes as the merging actor); only bot/app merges leave them open. Keep the verify-after-merge habit either way. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-bullet correction in CLAUDE.md's GitHub section: "PRs merge via
icebergai-review-bot, soCloses #nnever auto-closes" proved over-broad this week — agh pr mergerun as a human actor closes linked issues normally (GitHub closes as the merging actor); only bot/app merges leave them open. The verify-after-merge habit stays either way.🤖 Generated with Claude Code