Brand: use the shared IcebergAI mark in the rail and login page - #285
Merged
Conversation
Replaces the hand-drawn triangle glyph in _glyph.html with the real IcebergAI brand mark — the dark rounded chip used by IcebergTTX and IcebergEBS (canonical source: .github/profile/assets/icebergai-mark.svg) — self-hosted at static/img/icebergai-mark.svg. Both surfaces render through the single _glyph.html include; .brand-mark sizing moves 22px → 30px to match the siblings' rail treatment. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
IcebergAutoReview
Verdict: approve
The scoped branding change is correct, secure, and consistent with existing static asset/CSP conventions. The shared include updates both intended surfaces, and the decorative image has appropriate empty alt text and fixed dimensions.
Findings
- No blocking findings.
Validation
- Inspected the complete one-commit diff and affected template/CSS context against main.
- Parsed the SVG successfully and verified its 400×400 viewBox.
- Scanned the SVG for scripts, event handlers, external references, data URIs, and foreignObject content; none found.
- Ran
git diff --check main...HEAD; passed. - Attempted
tests/test_frontend_assets.py, but local dependencies were unavailable and the read-only workspace preventeduvfrom creating a virtual environment. Current-head CI is green.
Residual risks / optional notes
- Byte-for-byte equivalence with the separately hosted canonical brand asset could not be independently verified because that source asset is not present in this checkout.
Automated review by Codex 249069d1b5bf using IcebergAutoReview.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_glyph.htmlwith the real IcebergAI brand mark — the dark rounded chip already used by IcebergTTX and IcebergEBS (byte-identical to the canonical.github/profile/assets/icebergai-mark.svg), self-hosted atstatic/img/icebergai-mark.svg._glyph.htmlinclude, so one file swap covers both..brand-marksizing moves 22px → 30px to match the siblings' rail treatment; the chip carries its own background + rounding so it works on the dark rail and the light auth card alike.Testing
tests/test_frontend_assets.py(10 passed) all green./static/img/icebergai-mark.svgserves 200 under the existing static mount (CSPimg-src 'self'unaffected).🤖 Generated with Claude Code