Feature/i18n loading and persistence improvements#29
Open
DenisValcke wants to merge 5 commits into
Open
Conversation
IbenTesara
reviewed
Jul 13, 2026
| * | ||
| * By only switching out the translations when they are loaded, we close that gap. | ||
| */ | ||
| return this.translateService.currentLoader |
Owner
There was a problem hiding this comment.
Looks really good! Let me know once you've been able to test this in the test-application, then this can be merged 🙏
Contributor
Author
There was a problem hiding this comment.
I've expanded the test application to include two lazy-loaded libs with scoped translations. One of both libs has a resolver with a delay to give an accurate feel of how it would react to a delayed lib loading. I've also added some basic styling to visualize this loading state so that the test application doesn't appear broken during that delay.
Contributor
Author
There was a problem hiding this comment.
@IbenTesara I've also provided a screen capture of me testing this:
https://github.com/user-attachments/assets/f293c700-c370-4b81-b9eb-7909059e9694
…ons and a resolver that mocks delay of the page (in lib-2) to test and demo ngx-i18n implementations
…n.loader unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @IbenTesara
Just some proposals for fixes for the i18n lib. Can you take a look and give your opinion on them?
I think the second commit could be a fix for this issue as well: #27, or at least as close to a fix as possible without needing to wait on Navigation changes (end) in a resolver or create side-effects on that process.
Note: These changes are theoretical. I've not yet been able to actually test them within my own codebase.