fix(server): improve pipeline execution and row count accuracy#45
Merged
Conversation
- Use uuidv7 instead of crypto.randomUUID for row IDs (sortable) - Fix row count to use actual pipeline result length instead of potentially stale rawEventCount - Defer parquet writes so pipeline results are available immediately - Compute histogram from eventsResultPath instead of all chunk paths - Use proper drizzle eq() helper instead of raw SQL for deleteEntry - Consolidate @cruncher/server-shared imports into a single statement - Pass autoCompleteKeys through session restore path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uuidv7instead ofcrypto.randomUUIDfor sortable row IDsrawEventCounteventsResultPathinstead of all chunk pathseq()helper instead of raw SQL indeleteEntry@cruncher/server-sharedimports into a single statementautoCompleteKeysthrough session restore pathTest plan